AR: Clarify itrigger behavior. #901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I would say that the trigger fires after the trap. This says "when the trigger fires" we first do the trap behavior. It seems clearer to me to say that the trap happens and we do all the normal trap stuff then after that the trigger fires and we do all the normal trigger stuff.
timsifive
force-pushed
the
itrigger_det
branch
from
be9c416
to
5f4a2f2
Compare
|
Yes, I like this better. Thanks. |
Specifically, make clear that itrigger fires *after* the original exception has finished updating all the CSRs. Hopefully resolves #890.
timsifive
force-pushed
the
itrigger_det
branch
from
5f4a2f2
to
b699db6
Compare
|
Made the same change for etrigger. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically, make clear that itrigger fires after the original exception has finished updating all the CSRs.
Hopefully resolves #890.