Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AR: Comment itrigger limited to 32 ints if XLEN=32 #906

Merged
merged 1 commit into from Oct 19, 2023
Merged

Conversation

timsifive
Copy link
Contributor

Resolves #904.

Copy link
Collaborator

@pdonahue-ventana pdonahue-ventana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that the priv spec reserves 32-47. I think that it's AIA that does so. The priv spec says that >= 16 are designated for platform use (both in table 3.6 and table 9.6).

@timsifive
Copy link
Contributor Author

You're right. I must have been looking at the exceptions when I wrote that.

So this is another in-future-versions-of-the-spec thing. Getting really tired of updating our spec to work with a document that doesn't even exist in draft form.

Comment on lines 1145 to 1146
If XLEN is 32, then it is not possible to set a trigger interrupts with
Exception Code larger than 31. A future version of the RISC-V Privileged
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parser error: "a trigger interrupts" doesn't seem right to me. Maybe this?

Suggested change
If XLEN is 32, then it is not possible to set a trigger interrupts with
Exception Code larger than 31. A future version of the RISC-V Privileged
If XLEN is 32, then it is not possible to set a trigger for interrupts with
Exception Code larger than 31. A future version of the RISC-V Privileged

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Thanks.

@timsifive timsifive merged commit 95b06b0 into master Oct 19, 2023
1 check passed
@timsifive timsifive deleted the itrigger_limit branch October 19, 2023 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

For MXLEN=32, can't trigger on interrupts 32 or higher
2 participants