Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused wavedrom files #1588

Closed
kersten1 opened this issue Aug 8, 2024 · 2 comments
Closed

Unused wavedrom files #1588

kersten1 opened this issue Aug 8, 2024 · 2 comments

Comments

@kersten1
Copy link
Collaborator

kersten1 commented Aug 8, 2024

The following wavedrom files are not referenced anywhere in the isa. Delete them?

fnmaddsub.edn
cr-register-new.edn
half-store.edn
hint-nopv_rv32i.edn
hint-nopv_rv64i.edn
immediate_variants2.adoc
nop-v.edn
sploat2.adoc
zifencei-fetch.edn

These 2 are referenced but are in commented out sections:
cr-register.edn (commented out)
zihintpause-hint.edn (commented out)

Some were renamed to .edn before I realized that they weren't referenced, hence the mix of adoc and edn files. I did, however, search on just the name and not the file extension :)

@aswaterman
Copy link
Member

We should delete them. (They'll live on in git history, anyway.)

@kersten1
Copy link
Collaborator Author

Deleted all but the 2 that are still referenced but commented out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants