Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add glossary #47

Merged
merged 6 commits into from
Apr 25, 2024
Merged

add glossary #47

merged 6 commits into from
Apr 25, 2024

Conversation

rsahita
Copy link
Collaborator

@rsahita rsahita commented Apr 24, 2024

add glossary to address issue #42

@rsahita
add glossary
b7aca88 
Signed-off-by: Ravi Sahita <ravi@rivosinc.com>
@rsahita rsahita mentioned this pull request Apr 24, 2024
Closed
@rsahita rsahita requested a review from ved-rivos April 24, 2024 23:02
ved-rivos
ved-rivos reviewed Apr 24, 2024
View reviewed changes
glossary.adoc Outdated Show resolved Hide resolved
ved-rivos
ved-rivos reviewed Apr 24, 2024
View reviewed changes
glossary.adoc Outdated Show resolved Hide resolved
ved-rivos
ved-rivos reviewed Apr 24, 2024
View reviewed changes
glossary.adoc Outdated Show resolved Hide resolved
ved-rivos
ved-rivos reviewed Apr 24, 2024
View reviewed changes
glossary.adoc Outdated Show resolved Hide resolved
ved-rivos
ved-rivos reviewed Apr 24, 2024
View reviewed changes
glossary.adoc Outdated Show resolved Hide resolved
ved-rivos
ved-rivos reviewed Apr 24, 2024
View reviewed changes
glossary.adoc Outdated Show resolved Hide resolved
ved-rivos
ved-rivos reviewed Apr 24, 2024
View reviewed changes
glossary.adoc Outdated Show resolved Hide resolved
ved-rivos
ved-rivos reviewed Apr 24, 2024
View reviewed changes
glossary.adoc Outdated Show resolved Hide resolved
ved-rivos
ved-rivos reviewed Apr 24, 2024
View reviewed changes
glossary.adoc Outdated Show resolved Hide resolved
ved-rivos
ved-rivos reviewed Apr 24, 2024
View reviewed changes
glossary.adoc Outdated Show resolved Hide resolved
ved-rivos
ved-rivos reviewed Apr 24, 2024
View reviewed changes
glossary.adoc Outdated Show resolved Hide resolved
ved-rivos
ved-rivos reviewed Apr 24, 2024
View reviewed changes
glossary.adoc Outdated Show resolved Hide resolved
rsahita
rsahita commented Apr 24, 2024
View reviewed changes
glossary.adoc Outdated Show resolved Hide resolved
rsahita
rsahita commented Apr 24, 2024
View reviewed changes
glossary.adoc Outdated Show resolved Hide resolved
ved-rivos
ved-rivos reviewed Apr 24, 2024
View reviewed changes
glossary.adoc Outdated Show resolved Hide resolved
@rsahita @ved-rivos
Apply suggestions from PR review
731c29e 
Co-authored-by: Ved Shanbhogue <91900059+ved-rivos@users.noreply.github.com>
Signed-off-by: Ravi Sahita <rsahita@yahoo.com>
ved-rivos
ved-rivos reviewed Apr 24, 2024
View reviewed changes
glossary.adoc Outdated Show resolved Hide resolved
ved-rivos
ved-rivos reviewed Apr 24, 2024
View reviewed changes
glossary.adoc Outdated Show resolved Hide resolved
ved-rivos
ved-rivos approved these changes Apr 24, 2024
View reviewed changes
Copy link
Collaborator

@ved-rivos ved-rivos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left a few suggestions.

rsahita
rsahita commented Apr 24, 2024
View reviewed changes
glossary.adoc Outdated Show resolved Hide resolved
rsahita
rsahita commented Apr 25, 2024
View reviewed changes
glossary.adoc Outdated Show resolved Hide resolved
rsahita
rsahita commented Apr 25, 2024
View reviewed changes
glossary.adoc Outdated Show resolved Hide resolved
rsahita and others added 2 commits April 24, 2024 21:27
@rsahita @ved-rivos
Apply suggestions from PR review
7cf98b6 
Co-authored-by: Ved Shanbhogue <91900059+ved-rivos@users.noreply.github.com>
Signed-off-by: Ravi Sahita <rsahita@yahoo.com>
@rsahita @ved-rivos
Apply suggestions from PR review
345fd85 
Co-authored-by: Ved Shanbhogue <91900059+ved-rivos@users.noreply.github.com>
Signed-off-by: Ravi Sahita <rsahita@yahoo.com>
rsahita
rsahita commented Apr 25, 2024
View reviewed changes
glossary.adoc Outdated Show resolved Hide resolved
rsahita
rsahita commented Apr 25, 2024
View reviewed changes
glossary.adoc Outdated Show resolved Hide resolved
@rsahita
Apply suggestions from PR review
f5faeff 
Signed-off-by: Ravi Sahita <rsahita@yahoo.com>
rsahita
rsahita commented Apr 25, 2024
View reviewed changes
glossary.adoc Outdated Show resolved Hide resolved
rsahita
rsahita commented Apr 25, 2024
View reviewed changes
glossary.adoc Outdated Show resolved Hide resolved
rsahita
rsahita commented Apr 25, 2024
View reviewed changes
glossary.adoc Outdated Show resolved Hide resolved
@rsahita
Apply suggestions from PR review
cc8a604 
Signed-off-by: Ravi Sahita <rsahita@yahoo.com>
rsahita
rsahita commented Apr 25, 2024
View reviewed changes
Copy link
Collaborator Author

@rsahita rsahita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated @ved-rivos

@rsahita rsahita merged commit 5b7c213 into main Apr 25, 2024
1 check passed
@rsahita rsahita deleted the topic/glossary branch April 25, 2024 04:38
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ved-rivos ved-rivos ved-rivos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rsahita @ved-rivos