Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

Deduplicate and split platforms #17

Closed
4 tasks done
JohnAZoidberg opened this issue May 3, 2021 · 5 comments
Closed
4 tasks done

Deduplicate and split platforms #17

JohnAZoidberg opened this issue May 3, 2021 · 5 comments

Comments

@JohnAZoidberg
Copy link
Collaborator

JohnAZoidberg commented May 3, 2021

Currently we are working on the following platforms:

  • Sifive Hifive Unleashed
  • QEMU virt platform
  • BeagleV

Currently only the first one is on the main branch and upstreamed. The other two have WIP branches where they don't have their own platform but only the Hifive Unleashed code is modified.

Progress

On branch riscv-virt-gh-actions

  • Move generic OpenSbiPlatformLib to Platforms/RISCV/PlatformPkg
  • Have RiscvVirt use generic OpenSbiPlatformLib
  • Have U540 and U500 use generic OpenSbiPlatformLib
  • Deduplicate PlatformPei

- [ ] Follow MinPlatform See #24

@JohnAZoidberg
Copy link
Collaborator Author

OpenSBI platform files are generic now. They're only configured by the device tree.
So we can move the OpenSbiPlatformLib to RISC-V/PlatformPkg.

@JohnAZoidberg
Copy link
Collaborator Author

The DSC and FDF files could be deduplicated by implementing MinPlatform.

@JohnAZoidberg
Copy link
Collaborator Author

@JohnAZoidberg
Copy link
Collaborator Author

JohnAZoidberg commented May 5, 2021

What's remaining is https://github.com/riscv/riscv-edk2-platforms/blob/master/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/Universal/Pei/PlatformPei/
These are 300 lines of code that could be shared and be configured using a couple of PCDs on each platform.

@JohnAZoidberg
Copy link
Collaborator Author

Done with 36bcc51 and 1442441

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant