Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

select * panic in subquery #820

Closed
skyzh opened this issue Dec 3, 2023 · 4 comments
Closed

select * panic in subquery #820

skyzh opened this issue Dec 3, 2023 · 4 comments

Comments

@skyzh
Copy link
Member

skyzh commented Dec 3, 2023

> create table t1(v1 int, v2 int);
> explain select * from (select v1 + v1 as v3 from t1) as left;
thread 'main' panicked at 'called `Option::unwrap()` on a `None` value', src/planner/rules/plan.rs:266:51
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
@caicancai
Copy link
Contributor

It's possible to return a default value when capturing None, I'm not sure that's a good idea

@wangrunji0408
Copy link
Member

wangrunji0408 commented Dec 7, 2023

This bug has been fixed in #796. However, it has not been merged for a long time. 🥲
I can't recall too many details for now. But in my mind, this involves a tricky way how we handle the output of subquery. I might write an article to explain it in detail. (

@caicancai
Copy link
Contributor

This bug has been fixed in #796. However, it has not been merged for a long time. 🥲 I can't recall too much details for now. But in my mind, this involves a tricky way how we handle the output of subquery. I might write an article to explain it in detail. (

#796 looks very cool, looking forward to the author’s article

@wangrunji0408
Copy link
Member

fixed by #796

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants