-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(frontend): support create table with connector syntax #7110
Conversation
3dc2464
to
9bdbac5
Compare
Codecov Report
@@ Coverage Diff @@
## main #7110 +/- ##
==========================================
- Coverage 73.14% 73.13% -0.02%
==========================================
Files 1054 1054
Lines 168550 168645 +95
==========================================
+ Hits 123294 123342 +48
- Misses 45256 45303 +47
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Is this a user-facing change? |
Yes. But this feature has not been completed yet, for there exist some limits (such as the user cannot perform DML on table created with a connector now). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
generally LGTM, PTAL @tabVersion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. good work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rubber stamp
I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
Summarize your change
Support syntax:
This is equivalent to
CREATE MATERIALIZED SOURCE
.Describe any limitations of the current code
DROP TABLE
may not work as expected. This will be fixed after unsupportingCREATE MATERIALIZED SOURCE
.CREATE MATERIALIZED SOURCE
(so I could rename allCREATE MATERIALIZED SOURCE
toCREATE TABLE
).Checklist
./risedev check
(or alias,./risedev c
)Documentation
If your pull request contains user-facing changes, please specify the types of the changes, and create a release note. Otherwise, please feel free to remove this section.
Types of user-facing changes
Please keep the types that apply to your changes, and remove those that do not apply.
Release note
Please create a release note for your changes. In the release note, focus on the impact on users, and mention the environment or conditions where the impact may occur.
Refer to a related PR or issue link (optional)
#5949