Replace list of all job states with rivertype.JobStates()
#310
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small change that removes a list of all job states defined in
insert_opts.go
that was used to validate states sent intoUniqueOpts
with
rivertype.JobStates()
which was introduced recently n #297.Removing one of the lists means we only need to maintain one of them.
I left the variable in place instead of invoking
rivertype.JobStates()
so that we don't need to initialize a new slice every time we validate.