Replace list of all job states with rivertype.JobStates()
#310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandur
force-pushed
the
brandur-replace-job-state-list
branch
from
f38f502
to
f653544
Compare
bgentry
approved these changes
May 2, 2024
A small change that removes a list of all job states defined in `insert_opts.go` that was used to validate states sent into `UniqueOpts` with `rivertype.JobStates()` which was introduced recently n #297. Removing one of the lists means we only need to maintain one of them. I left the variable in place instead of invoking `rivertype.JobStates()` so that we don't need to initialize a new slice every time we validate.
brandur
force-pushed
the
brandur-replace-job-state-list
branch
from
f653544
to
19c5da7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small change that removes a list of all job states defined in
insert_opts.gothat was used to validate states sent intoUniqueOptswith
rivertype.JobStates()which was introduced recently n #297.Removing one of the lists means we only need to maintain one of them.
I left the variable in place instead of invoking
rivertype.JobStates()so that we don't need to initialize a new slice every time we validate.