-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix river.JobStateAvailable
reference in cmd/river/
#315
Conversation
@@ -1465,7 +1465,7 @@ type JobListResult struct { | |||
// provided context is used for the underlying Postgres query and can be used to | |||
// cancel the operation or apply a timeout. | |||
// | |||
// params := river.NewJobListParams().WithLimit(10).State(river.JobStateCompleted) | |||
// params := river.NewJobListParams().WithLimit(10).State(rivertype.JobStateCompleted) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found these via git grep -n river.JobState
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for submitting a fix so quickly! 🙏🏻
@bgentry You've got to approve CI to run here (Thanks for the LGTM BTW 😆) |
Oh shoot, I can't merge it either, sorry for the ping @bgentry! |
Thanks @dhermes. Out of curiosity, you said you actually ran into an error because of this? I would not have expected this to happen because unlike other internal Go modules, Do you have something exotic going on in your build, or am I missing something? |
A small release containing the change in #315. I don't _think_ anything critical was broken, but not completely certain, and a release is an easy thing to do, so just in case. Also update `./cmd/river`'s references to `v0.4.0` which shouldn't affect anything, but a minor nicety to stay current.
A small release containing the change in #315. I don't _think_ anything critical was broken, but not completely certain, and a release is an easy thing to do, so just in case. Also update `./cmd/river`'s references to `v0.4.0` which shouldn't affect anything, but a minor nicety to stay current.
A small release containing the change in #315. I don't _think_ anything critical was broken, but not completely certain, and a release is an easy thing to do, so just in case. Also update `./cmd/river`'s references to `v0.4.0` which shouldn't affect anything, but a minor nicety to stay current.
@brandur We have We vendor in I suppose the build cost could be paid upfront and placed in a GitHub Action (e.g. via something like https://full-stack.blend.com/how-we-write-github-actions-in-go.html), just haven't realized there was a need until (maybe) right now. |
@dhermes Ah gotcha! Okay that makes sense. Thanks for explaining. |
A very small one: I forgot to add changelog attribution for #315. This seems like a nice convention for recognizing third party contributors, so here, put some in.
A very small one: I forgot to add changelog attribution for #315. This seems like a nice convention for recognizing third party contributors, so here, put some in.
rivertype
0.4.0
release this morning (thanks @dependabot!);cmd/river/
won't build in the release (didn't realize these aliases were still until Removeriver.JobState*
aliases in favor of usingrivertype
directly #300)