Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build prepackaged Cutter using Qt6 for macOS and Windows #3223

Closed
3 tasks done
XVilka opened this issue Aug 5, 2023 · 1 comment
Closed
3 tasks done

Build prepackaged Cutter using Qt6 for macOS and Windows #3223

XVilka opened this issue Aug 5, 2023 · 1 comment
Labels
Build System Help Wanted macOS Qt Issues and pull-requests regarding or caused-by the underlying Qt toolkit. Windows
Milestone
2.4

Comments

@XVilka
Copy link
Member

XVilka commented Aug 5, 2023 •
edited
Loading

Currently, Qt5 is being used. Time to make the Qt6 the default choice when available. It will improve High DPI experience as well: #1827

See:

Will boils down to build with -DCUTTER_QT6=ON

See also rizinorg/cutter-deps#15

See https://doc.qt.io/qt-6/macos-deployment.html#the-mac-deployment-tool

Affected files:

  • .github/workflows/ci.yml
  • dist/CMakeLists.txt
  • dist/MacOSSetupBundle.cmake.in
  • dist/WindowsBundleQt.cmake
  • dist/appbundle_embed_python.sh (PySide)
@XVilka XVilka added Build System Qt Issues and pull-requests regarding or caused-by the underlying Qt toolkit. labels Aug 5, 2023
@XVilka XVilka added this to the 2.4 milestone Aug 5, 2023
@XVilka XVilka mentioned this issue Jan 18, 2024
Closed
3 tasks
@karliss
Copy link
Member

karliss commented Jul 27, 2024

Done in #3363

@karliss karliss closed this as completed Jul 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Build System Help Wanted macOS Qt Issues and pull-requests regarding or caused-by the underlying Qt toolkit. Windows
Projects
None yet
Milestone
2.4
Development

Successfully merging a pull request may close this issue.

WIP Use Qt6 by default rizinorg/cutter
2 participants
@XVilka @karliss