-
-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Windows and Jemalloc heap parsing tests #158
Comments
I'm the author of https://github.com/rizinorg/rizin/blob/dev/test/db/archos/linux-x64/dbg_dmht, every binary inside bins/elf/ has a patchef interpreter/linker. Example:
Now I'm particularly busy to continue working on this |
@PulakIIIT regarding this. Currently heap parsing is running only on Linux. But the heap parsing is untied to the debugger. What about making existing heap parsing tests static? So they will be runned on all supported platforms - e.g. Linux glibc binary heap would be parsed even on Windows, MacOS, FreeBSD. |
Can you elaborate more or provide some relevant links? I am a bit confused, I do not understand how Glibc binary can be run on a platform like MacOS. |
@PulakIIIT idea is not to run these binaries. Idea is to:
This way we will preserve old versions support easier, since these snapshots will not be touched since. Just see the issue description - it doesn't use any debugging, so it can be moved into platform-independent tests directory. |
Thanks this was helpful. One more thing, as mentioned in #157 the heap parsing code currently compiled as per the OS. So currently when we save the memory map on Linux with glibc binary, it will be interpreted by Jemalloc on macOS, right? Will this cause any issues? |
@PulakIIIT right, so this should be fixed first. I think it's better to do a minor refactoring, to just allow it to be built on all platforms, without doing major changes. This would allow us to create static tests that in turn would help us with further, cleaner refactoring of the heap parsing code. What do you think about this approach? |
Yeah this approach sounds good to me. I will start working on the minor refactor. |
@GustavoLCR could you please also address this when you have some time? |
Currently only glibc heap is tested with
Note, that this static test probably should be moved under a separate category
heap
, since not really dependent from the operating system.We need add this static tests for Windows heap parser and jemalloc too.
cc @GustavoLCR @meowmeowxw
The text was updated successfully, but these errors were encountered: