Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

librz/cons/* (TUI library/) - remove global state #276

Open
ghost opened this issue Dec 27, 2020 · 2 comments
Open

librz/cons/* (TUI library/) - remove global state #276

ghost opened this issue Dec 27, 2020 · 2 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed refactor Refactoring requests RzCons
Milestone

Comments

@ghost
Copy link

ghost commented Dec 27, 2020

Remove global variables

librz/cons/input.c

#define I rz_cons_singleton()

Additional context

Also related: #985

@XVilka
Copy link
Member

XVilka commented Dec 28, 2020

I don't think we need to use any external library. So far, Rizin's own is battle tested across different systems and environments, and much smaller than alternatives. We don't require all features of the "bigger" libraries, thus I think it's better to keep it.

@XVilka XVilka added the refactor Refactoring requests label Dec 28, 2020
@ret2libc
Copy link
Member

ret2libc commented Jan 3, 2021

That said, it would definitely benefit from more unit tests and better API, as all the other librz modules :(

@stale stale bot added the stale label Jul 8, 2021
@stale stale bot removed the stale label Aug 3, 2021
@XVilka XVilka changed the title /libr/cons/* (TUI library) refactoring librz/cons/* (TUI library) refactoring Aug 3, 2021
@XVilka XVilka added the RzCons label Aug 3, 2021
@XVilka XVilka added good first issue Good for newcomers help wanted Extra attention is needed labels Sep 13, 2021
@XVilka XVilka changed the title librz/cons/* (TUI library) refactoring librz/cons/* (TUI library/) - remove global state Sep 13, 2021
@rizinorg rizinorg deleted a comment from stale bot Sep 13, 2021
@XVilka XVilka added this to the 0.5.0 milestone Jan 25, 2022
@stale stale bot added the stale label Jul 30, 2022
@rizinorg rizinorg deleted a comment from stale bot Nov 6, 2022
@XVilka XVilka modified the milestones: 0.5.0, 0.6.0 Jan 24, 2023
@XVilka XVilka removed the stale label May 6, 2023
@XVilka XVilka removed this from the 0.6.0 milestone Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed refactor Refactoring requests RzCons
Projects
Status: To do
2 participants