-
-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backports from radare2 #747
Comments
I don't think porting Coverity fixes makes sense since we have our own Coverity instance, so we could just use it. |
This comment has been minimized.
This comment has been minimized.
I would not trust these without tests. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
4 tasks
4 tasks
@XVilka @thestr4ng3r can we close this? We are not following r2 anymore, I think. |
for me is ok to close this. |
Certain changes in ELF parsing are worth packporting. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Enhancements
Finished and rejected
radareorg/radare2@e3b5991: see RzUtil: add unit tests for rz_str_ndup/nlen #1419 right now i could not find any issue with those functions, so i'm not backportingasm.cpu
forasm.arch=ppc.gnu
#1278radareorg/radare2@acf4693You can see the changes to tests has been essentially reverted in radareorg/radare2@3fedf80#diff-4966e4f1fa478276b4c6424b2ae54c6216ed6311b8c3b7d43976b71070307236 . The output of r2 and rizin are the same now, so we can skip this.radareorg/radare2@0977e61let's fix this when we encounter the problem. With proper tests as well.https://github.com/radareorg/radare2/pull/18483/filessome things have already been patched. others i cannot find. i think we can just skip this.radareorg/radare2@a0213f0we can fix our coverity issues ourselves. I think it's safer, easier than trying to backport things happening on a now very different codebase.Fix coverity vulnerabilities 2 radareorg/radare2#18521we can fix our coverity issues ourselves. it's just easier.radareorg/radare2@c150dc4this seems wrong becausedisassembler_options
is achar *
and options is a local var on the stack. Anyway, we are fixing this in our own PR.radareorg/radare2@57a9926some small refactoring in cons grep.c. I think we can do that ourselves at some point.Plan 9 binary format
at this point rzbin plugins are quite different as we have maps to map things, so not sure it's worth backporting. it would be a rewrite of the plugin in other words.
Enhancements signatures
all skip because signatures were heavily refactored already by wargio.
The text was updated successfully, but these errors were encountered: