add [MetaJSON] to [@Basic] #554
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karenetheridge
force-pushed
the
topic/metajson_basic
branch
3 times, most recently
from
345eac6
to
43cd80b
Compare
|
It would be helpful to document this v6 change in the Pod of |
| @@ -45,6 +46,7 @@ It includes the following plugins with their default configuration: | |||
| * L<Dist::Zilla::Plugin::PruneCruft> | |||
| * L<Dist::Zilla::Plugin::ManifestSkip> | |||
| * L<Dist::Zilla::Plugin::MetaYAML> | |||
| * L<Dist::Zilla::Plugin::MetaJSON> | |||
There was a problem hiding this comment.
@dolmen The plugin membership is listed here -- where else should it go?
There was a problem hiding this comment.
I was think about something more visible (well, as far as POD for a PluginBundle can be considered visible) such as a block in the DESCRIPTION section:
B<Note:> L<[MetaCPAN]|Dist::Zilla::Plugin::MetaJSON> is included since Dist::Zilla v6.
|
I'm not sure how I feel about special casing "can appear twice, whatever!" in a specific plugin, rather than just forcing people to update. I'm going to put this off for now. |
|
The problem with having two MetaJSONs being a fatal error is that if then the distribution is built against Dist::Zilla |
karenetheridge
force-pushed
the
topic/metajson_basic
branch
from
43cd80b
to
6c52ad2
Compare
karenetheridge
force-pushed
the
topic/metajson_basic
branch
from
6c52ad2
to
c03f843
Compare
karenetheridge
force-pushed
the
topic/metajson_basic
branch
from
c03f843
to
62ef27a
Compare
karenetheridge
force-pushed
the
topic/metajson_basic
branch
2 times, most recently
from
4879151
to
2b77e25
Compare
karenetheridge
force-pushed
the
topic/metajson_basic
branch
3 times, most recently
from
d1605c2
to
9947478
Compare
Dist::Zilla::Dialect is a multi-import pragma to set up v5.20 and the features used by Dist::Zilla code code: the good stuff from v5.20 and thereabouts.
...as inspired by File::HomeDir::Tiny
Note that all of this can be replaced by (glob('~'))[0] when perl 5.20
is required.
This will prevent discouraged formats from being used, even though CPAN::Meta still lets some of them in (despite contradictory language in CPAN::Meta::Spec). Following the Lyon version roundtable, _ is no longer interpreted as another dot in non-decimal versions, so the sort order can now be different.
even on MSWin32
karenetheridge
force-pushed
the
topic/metajson_basic
branch
from
9947478
to
b45072a
Compare
karenetheridge
force-pushed
the
topic/metajson_basic
branch
from
b45072a
to
24eac4c
Compare
|
updated to v7-in-progress. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.