-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transmoogrification - Moose => Moo conversion of HTTP::Throwable #5
Conversation
Forced-push some minor fixes, thanks to Mithaldu++! |
* per haarg: Moo::Object is undocumented as part of the Moo API and shouldn't be relied upon. Instead, only run the extends if the user overrides base_class.
Is this merge-ready? it would be great to no longer have to pay the Moose tax when used with Catalyst. |
+1 |
I will test this against my work code base uses of HTTP-Throwable and either release or review by next week. (It's on my calendar now!) |
I have tested my code against this, and it looks okay. All of the roles had I will fix this locally, but please keep that in mind next time you do a transmoogrification like this. |
I have uploaded HTTP-Throwable-0.021-TRIAL.tar.gz. I'll give this a while before making it the stable version. |
FWIW, I catch this via my dzil author bundle by including |
This has been released as v0.022. Thank you for all your efforts! |
Hello Ricardo,
This patchset switches HTTP::Throwable from Moose to Moo-based. It passes all of the current tests, and I've also tested it with the Moose-based subclassing in timbunce/WebAPI-DBIC. I've added dependecies on Type::Tiny, Types::Standard, Package::Variant, and namespace::clean. Please let me know if there's anything you would like me to change or fix. Thank you and have a great day!
Cheers,
Fitz