Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

print method and y_time #11

Open
AQLT opened this issue Nov 10, 2023 · 2 comments
Open

print method and y_time #11

AQLT opened this issue Nov 10, 2023 · 2 comments

Comments

@AQLT
Copy link

AQLT commented Nov 10, 2023

I think the parameter y_time should be optional. For example, the print method currently returns an error if the parameter is not specified

mod <- rjd3highfreq::fractionalAirlineDecomposition(
    y = forecast::taylor,
    period = 2*24*7,
    log = FALSE)
mod
#> Number of observations:  4032
#> 
#> Estimate MA parameters:
#>         MA_parameter       Coef    Coef_SE     Tstat
#>             Theta(1) -0.1792827 0.01659386 -10.80416
#>  Theta(period = 336)  0.3006010 0.01774463  16.94039
#> Additive model
#> 
#> Decomposition:
#> Error in eval(substitute(select), nl, parent.frame()): object 'y_time' not found
@TanguyBarthelemy
Copy link
Contributor

Yes it's an optional argument.
I left a typo in the print code. I'm going to make a pull request.

@TanguyBarthelemy
Copy link
Contributor

It's corrected!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants