Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

B command doesn't open a file #24

Closed
rjkroege opened this issue Apr 2, 2018 · 8 comments
Closed

B command doesn't open a file #24

rjkroege opened this issue Apr 2, 2018 · 8 comments
Assignees

Comments

@rjkroege
Copy link
Owner

rjkroege commented Apr 2, 2018

The B command failed to open anything.

Console output (possibly suspect) at roughly the same time:

9pserve: announce unix!/tmp/ns.rjkroege.:0/acme: Address already in use
acme: can't post service: 9pserve failed
@paul-lalonde
Copy link
Collaborator

No plumber support yet. Will add that next.

@paul-lalonde paul-lalonde self-assigned this Apr 2, 2018
@paul-lalonde
Copy link
Collaborator

8074242 adds rudimentary support.
But there's a bunch of caveats:

  • the executable must be called acme
  • It must open a socket called acme [as we do]. Calling it edwood breaks too much of the ecosystem.
  • It must be on the path in the right spot for the plumber to see it.
    The right way to proceed is probably to call our project acme.

@rjkroege
Copy link
Owner Author

rjkroege commented Apr 3, 2018

The plumber already supports sam and acme via config file. It ought to be easily configured to use edwood. edwood definitely needs to mount itself as acme.

@rjkroege
Copy link
Owner Author

rjkroege commented Apr 3, 2018

In particular, so long as edwood is in the path, then

9p read plumb/rules  | sed 's/acme/edwood/' | 9p write plumb/rules

@rjkroege
Copy link
Owner Author

rjkroege commented Apr 3, 2018

will make B work. It broke my plumbing config in other ways though for reasons having nothing to do with edwood.

@rjkroege
Copy link
Owner Author

rjkroege commented Apr 3, 2018

Some other plumbing stuff however requires fixing:

Unimplemented: main.plumbshow(0xc4203cb740): /Users/rjkroege/tools/gopkg/src/github.com/rjkroege/edwood/look.go:252 +0x20

@paul-lalonde
Copy link
Collaborator

Yep. Known still undone - there's a reason I didn't close this :-)

@paul-lalonde
Copy link
Collaborator

All working now, I think, as of d314d43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants