crash while deleting text at end of text

[rjkroege]

oops.

panic: runtime error: index out of range

goroutine 11 [running]:
github.com/rjkroege/edwood/frame.(*Frame).Delete(0xc4201a4fc0, 0x237, 0x238, 0x5d4)
	/Users/rjkroege/tools/gopkg/src/github.com/rjkroege/edwood/frame/delete.go:51 +0xdd2
main.(*Text).Delete(0xc420477d20, 0x237, 0x238, 0x0)
	/Users/rjkroege/tools/gopkg/src/github.com/rjkroege/edwood/text.go:608 +0x3a8
main.(*Text).Type(0xc420477d20, 0xc400000008)
	/Users/rjkroege/tools/gopkg/src/github.com/rjkroege/edwood/text.go:942 +0x8bb
main.(*Window).Type(0xc420477c00, 0xc420477d20, 0x8)
	/Users/rjkroege/tools/gopkg/src/github.com/rjkroege/edwood/wind.go:392 +0x37
main.(*Row).Type(0x12cde00, 0x8, 0x256, 0x3b6, 0x1)
	/Users/rjkroege/tools/gopkg/src/github.com/rjkroege/edwood/row.go:277 +0x139
main.keyboardthread(0xc4200ce0c0)
	/Users/rjkroege/tools/gopkg/src/github.com/rjkroege/edwood/acme.go:456 +0x274
created by main.main
	/Users/rjkroege/tools/gopkg/src/github.com/rjkroege/edwood/acme.go:181 +0x907

Note to self... Hit Put way more frequently.

[paul-lalonde]

I've not been able to reproduce this. Got more info?

[rjkroege]

I was editing and hit some combination of enter / delete keys. And ka-bam. Conceivably we need a scheme to better report / log failures.

[paul-lalonde]

I'm hitting a similar case when inserting at the end of a win buffer; The trace indicates something fishy when working at the very end of the buffer. You can repro this in a win (in rjkroege/edwood) by asking for something that gives lots of spew - I use grep func *.go and it's very reliable.

0 0x000000000102ebb0 in runtime.startpanic
at /usr/local/go/src/runtime/panic.go:591
1 0x000000000102e81a in runtime.gopanic
at /usr/local/go/src/runtime/panic.go:547
2 0x0000000001127007 in github.com/rjkroege/edwood/frame.(*Frame).Insert
at ./frame/insert.go:217
3 0x00000000011f542a in main.(*Text).Insert
at ./text.go:475
4 0x000000000120a37c in main.xfidwrite
at ./xfid.go:579
5 0x00000000012064a5 in main.xfidctl
at ./xfid.go:46
6 0x000000000105c6a1 in runtime.goexit
at /usr/local/go/src/runtime/asm_amd64.s:2361

[rjkroege]

Yet another case of Frame fragility.