Skip to content

Commit

Permalink
fix: Pass uiSchema to custom ArrayField (#2769)
Browse files Browse the repository at this point in the history
* fix: Pass uiSchema to custom ArrayField

* fix: Update ArrayField tests

* fix: cs-format fix
  • Loading branch information
bakajvo committed May 18, 2022
1 parent df3a4af commit 8863080
Show file tree
Hide file tree
Showing 2 changed files with 132 additions and 0 deletions.
3 changes: 3 additions & 0 deletions packages/core/src/components/fields/ArrayField.js
Original file line number Diff line number Diff line change
Expand Up @@ -567,6 +567,7 @@ class ArrayField extends Component {
onFocus={onFocus}
options={options}
schema={schema}
uiSchema={uiSchema}
registry={registry}
value={items}
disabled={disabled}
Expand Down Expand Up @@ -618,6 +619,7 @@ class ArrayField extends Component {
onFocus={onFocus}
options={options}
schema={schema}
uiSchema={uiSchema}
registry={registry}
value={items}
disabled={disabled}
Expand Down Expand Up @@ -660,6 +662,7 @@ class ArrayField extends Component {
onBlur={onBlur}
onFocus={onFocus}
schema={schema}
uiSchema={uiSchema}
title={title}
value={items}
disabled={disabled}
Expand Down
129 changes: 129 additions & 0 deletions packages/core/test/ArrayField_test.js
Original file line number Diff line number Diff line change
Expand Up @@ -265,6 +265,22 @@ describe("ArrayField", () => {
expect(node.querySelector("#custom")).to.exist;
});

it("should pass uiSchema to normal array field", () => {
const { node } = createFormComponent({
schema,
uiSchema: {
items: {
"ui:placeholder": "Placeholder...",
},
},
formData: ["foo", "barr"],
});

expect(
node.querySelectorAll("input[placeholder='Placeholder...']")
).to.have.length.of(2);
});

it("should pass rawErrors down to custom array field templates", () => {
const schema = {
type: "array",
Expand Down Expand Up @@ -1240,6 +1256,17 @@ describe("ArrayField", () => {
expect(matches).to.have.length.of(1);
expect(matches[0].textContent).to.eql(schema.title);
});

it("should pass uiSchema to multiselect", () => {
const { node } = createFormComponent({
schema,
uiSchema: {
"ui:enumDisabled": ["bar"],
},
});

expect(node.querySelector("option[value=bar]").disabled).to.eql(true);
});
});

describe("CheckboxesWidget", () => {
Expand Down Expand Up @@ -1343,6 +1370,27 @@ describe("ArrayField", () => {
"should NOT have fewer than 3 items"
);
});

it("should pass uiSchema to checkboxes", () => {
const { node } = createFormComponent({
schema: {
type: "array",
items: {
enum: ["foo", "bar", "fuzz"],
type: "string",
},
uniqueItems: true,
},
uiSchema: {
"ui:widget": "checkboxes",
"ui:options": {
inline: true,
},
},
});

expect(node.querySelectorAll(".checkbox-inline")).to.have.length.of(3);
});
});
});

Expand Down Expand Up @@ -1426,6 +1474,29 @@ describe("ArrayField", () => {
expect(node.querySelector("input[type=file]").id).eql("root");
});

it("should pass uiSchema to files array", () => {
const { node } = createFormComponent({
schema: {
type: "array",
items: {
type: "string",
},
},
uiSchema: {
items: {
"ui:widget": "file",
"ui:options": { accept: ".pdf" },
},
},
formData: [
"data:text/plain;name=file1.pdf;base64,dGVzdDE=",
"data:image/png;name=file2.pdf;base64,ZmFrZXBuZw==",
],
});

expect(node.querySelector("input[type=file]").accept).eql(".pdf");
});

it("should pass rawErrors down to custom widgets", () => {
const schema = {
type: "array",
Expand Down Expand Up @@ -1730,6 +1801,29 @@ describe("ArrayField", () => {
expect(node.querySelector(".array-item-add button")).to.be.null;
});

it("[fixed] should pass uiSchema to fixed array", () => {
const { node } = createFormComponent({
schema: {
type: "array",
items: [
{
type: "string",
},
{
type: "string",
},
],
},
uiSchema: {
items: {
"ui:widget": "textarea",
},
},
formData: ["foo", "bar"],
});
expect(node.querySelectorAll("textarea").length).to.eql(2);
});

describe("operations for additional items", () => {
const { node, onChange } = createFormComponent({
schema: schemaAdditional,
Expand Down Expand Up @@ -1862,6 +1956,41 @@ describe("ArrayField", () => {
expect(node.querySelectorAll("#custom-select")).to.have.length.of(2);
});

it("should pass uiSchema to custom widget", () => {
const CustomWidget = ({ uiSchema }) => {
return (
<div id="custom-ui-option-value">
{uiSchema.custom_field_key["ui:options"].test}
</div>
);
};

const { node } = createFormComponent({
schema: {
type: "array",
items: {
type: "string",
},
},
widgets: {
CustomWidget: CustomWidget,
},
uiSchema: {
"ui:widget": "CustomWidget",
custom_field_key: {
"ui:options": {
test: "foo",
},
},
},
formData: ["foo", "bar"],
});

expect(node.querySelector("#custom-ui-option-value").textContent).to.eql(
"foo"
);
});

it("if the schema has fixed items, it should still render the custom widget.", () => {
const schema = {
type: "array",
Expand Down

0 comments on commit 8863080

Please sign in to comment.