Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Pass uiSchema to custom ArrayField #2769

Merged
merged 13 commits into from
May 18, 2022

Conversation

bakajvo
Copy link
Contributor

@bakajvo bakajvo commented Mar 17, 2022

Reasons for making this change

This is similar issue like PR 2587 in BooleanFields. This PR fixes passing UISchema to ArrayFields.

Checklist

  • I'm adding or updating code
    • I've added and/or updated tests

@bakajvo
Copy link
Contributor Author

bakajvo commented Apr 5, 2022

Follow up on Issue 2793

@bakajvo
Copy link
Contributor Author

bakajvo commented May 16, 2022

Hello, can @epicfaace review it please? :)

Copy link
Member

@epicfaace epicfaace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! These tests are 💯, some of the cleanest and best I've seen in a while

@epicfaace
Copy link
Member

@bakajvo I think you need to run the format / prettier command though.

@bakajvo bakajvo requested a review from epicfaace May 16, 2022 14:07
@bakajvo
Copy link
Contributor Author

bakajvo commented May 16, 2022

@bakajvo I think you need to run the format / prettier command though.

@epicfaace Done, thx! :)

@epicfaace epicfaace merged commit 8863080 into rjsf-team:master May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants