-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to mui v5, variant 1 (fixes #2555) #2603
Upgrade to mui v5, variant 1 (fixes #2555) #2603
Conversation
- Copied the `material-ui` package to `mui-v5` and began the Material UI [V4 to V5 migration](https://mui.com/guides/migration-v4/) - Upgraded to react 17 and the latest types
…ial-ui/styles` to `@mui/material`, `@mui/icons-material` and `@mui/styles`
…or changes to the source (with one exception, TextareaWidget)
…variant for the default Material-UI v5 theme
…heme creation in `DemoFrame.js`
…failing `textarea field` test with a @mui issue, and updated snaps as a result of the skip
… and fixed the path name for mui-5 in the README.md
… the themes.md in the docs - Also reverted the root and playground `package-lock.json` files to minimize the size of the diff
…ependency - Updated `mui-5/screenshot.png`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. How do you think we should handle adding more and more code per new theme / version of material ui? Perhaps we should retire old versions of material ui themes after a while?
I'm also wondering whether it makes sense to call it @rjsf/mui-5or instead just publish a breaking change for
@rjsf/material-ui`
I actually thought of a way to possibly have the material-ui theme support
both, with two themes in one. I will play with it on Monday and see if my
idea will work
…On Fri, Nov 12, 2021 at 7:20 PM Ashwin Ramaswami ***@***.***> wrote:
***@***.**** commented on this pull request.
Thanks for the PR. How do you think we should handle adding more and more
code per new theme / version of material ui? Perhaps we should retire old
versions of material ui themes after a while?
I'm also wondering whether it makes sense to call it @rjsf/mui-5or
instead just publish a breaking change ***@***.***/material-ui`
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2603 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMKJCZDCS3RTVQOGNHT36HDULXKOXANCNFSM5H6CR36Q>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
--
This e-mail is private and confidential and is for the addressee only. If
misdirected, please notify us by telephone, confirming that it has been
deleted from your system and any hard copies destroyed. You are strictly
prohibited from using, printing, distributing or disseminating it or any
information contained in it save to the intended recipient.
|
…now unnecessary `TextWidgetProps` in favor of `WidgetProps`
closing in favor of #2605 |
Reasons for making this change
Fix #2555 by adding the
mui-5
theme as follows:core
to add React 17 as a peer-dependency to supportmui-5
which requires itcreate-react-ref
library that didn't support React 17, updating the single usage of it in a test withReact.createRef()
material-ui
theme then ran the mui v4->v5 over the source codeInput
withOutlinedInput
to match the new default variantTextFieldProps
in favor of simply using the updatedWidgetProps
in may of theTextField
based widgetsmui-5/README.md
,mui/screenshot/png
and a few other theme related documentation filesplayground-r17
package that contains only thecore
andmui-5
themesreact-monoco-editor
,monoco-editor
andmonaco-editor-webpack-plugin
to versions that support React 17DemoFrame
to use the@emotion/react
CacheProvider
to replace the older@material-ui/styles
StylesProvider
Checklist