hide empty help label in antd form items #2780
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
momesana
force-pushed
the
fix_empty_help_label_in_antd
branch
from
a9eca90
to
3a4ef83
Compare
emmanueljohn1
approved these changes
Mar 27, 2022
momesana
force-pushed
the
fix_empty_help_label_in_antd
branch
2 times, most recently
from
3a4ef83
to
9e022a3
Compare
momesana
force-pushed
the
fix_empty_help_label_in_antd
branch
from
9e022a3
to
6082118
Compare
|
Is there anything else I could do to expedite the merge of this PR? |
|
Thanks -- do you mind adding it to the weekly meeting agenda? I think a synchronous review would be easiest -- #2677 |
epicfaace
reviewed
Apr 25, 2022
| @@ -65,7 +65,7 @@ const FieldTemplate = ({ | |||
| colon={colon} | |||
| extra={description} | |||
| hasFeedback={schema.type !== 'array' && schema.type !== 'object'} | |||
| help={(!!rawHelp && help) || (!!rawErrors && renderFieldErrors())} | |||
| help={rawHelp ? help : rawErrors ? randerFieldErrors() : undefined} | |||
There was a problem hiding this comment.
We also need to add a test here. Thanks!
heath-freenome
added
the
missing tests
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
fixes #2779Checklist