Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@rjsf-antd): Submit button type bug (#2867) #2869

Merged
merged 9 commits into from
May 25, 2022
58,661 changes: 29,245 additions & 29,416 deletions packages/antd/package-lock.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion packages/antd/src/widgets/SubmitButton/SubmitButton.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ const { getSubmitButtonOptions } = utils;
export default ({ uiSchema }) => {
const { submitText, norender, props: submitButtonProps }= getSubmitButtonOptions(uiSchema);
if (norender) {return null;}
return (<Button type="submit" {...submitButtonProps}>
return (<Button htmlType={"submit"} {...submitButtonProps}>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider simplifying this to htmlType="submit"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also I have done this.

{submitText}
</Button>);
};
Expand Down
8,869 changes: 4,432 additions & 4,437 deletions packages/bootstrap-4/package-lock.json

Large diffs are not rendered by default.

Loading