Skip to content
This repository has been archived by the owner on Jan 4, 2024. It is now read-only.

No support for emojis in the comments 😿 #56

Closed
marsrobertson opened this issue Jan 15, 2021 · 10 comments
Closed

No support for emojis in the comments 😿 #56

marsrobertson opened this issue Jan 15, 2021 · 10 comments
Labels
bug Something isn't working enhancement New feature or request help wanted Extra attention is needed

Comments

@marsrobertson
Copy link

General exception occured when attempting to insert record
Failed to verify 1 contract(s): Assurance

Running with --debug

Noticed emoji in the comments.

Removed emoji.

Now works.

@rkalis
Copy link
Owner

rkalis commented Jan 15, 2021

That sounds interesting! I'll look into this some time on the weekend.

@rkalis
Copy link
Owner

rkalis commented Jan 16, 2021

Actually let me tag @Enigmatic331 as well since the the error message appears to come form the Etherscan side.

@felixakiragreen
Copy link

I'm running into the same issue where I am am trying to verify a contract that has already been deployed to mainnet.

If it includes the emojis/special characters in the comments it fails, but without them it succeeds. (On testnet)

Unfortunately my contract is already deployed on mainnet.

@rkalis @marsrobertson Are you aware of any way to do the verification if it already includes the emojis/special characters? I now know not to include them for the future, but I'm a little stuck right now since I already deployed it weeks ago.

@rkalis
Copy link
Owner

rkalis commented Apr 21, 2021

You should be able to change the comments and still get it to verify on Etherscan since the comments don't impact the bytecode. In other words the comments in the verified version don't have to be exactly the same as in the deployed version.

@felixakiragreen
Copy link

felixakiragreen commented Apr 21, 2021

@rkalis 🙏 thanks so much. Trying now.

EDIT: It finally worked, thanks so much thanks so much thanks so much thanks so much thanks so much thanks so much thanks so much thanks so much thanks so much thanks so much thanks so much thanks so much thanks so much thanks so much thanks so much thanks so much thanks so much thanks so much thanks so much thanks so much thanks so much thanks so much thanks so much thanks so much thanks so much thanks so much thanks so much thanks so much thanks so much thanks so much

@rkalis rkalis added bug Something isn't working enhancement New feature or request help wanted Extra attention is needed labels May 7, 2021
@rkalis
Copy link
Owner

rkalis commented May 7, 2021

@Enigmatic331 do you have any idea why emojis cannot occur in the comments when submitting for verification?

@lebed2045
Copy link

lol, I can confirm this behaviour for https://testnet.bscscan.com/address/0xa8Ebf9a20aD4F9226346729BB0d4AEf67Eda185E#contracts - wasn't able to verify untill I removed 🐧

@rkalis
Copy link
Owner

rkalis commented Sep 10, 2021

@Enigmatic332 can I bump this to your attention, any idea why emojis are not allowed?

@Enigmatic331
Copy link

Enigmatic331 commented Sep 10, 2021

Ah crap - I think I fixed this but forget to mention this - One sec...

Yeap! Should be fixed now (e.g. https://ropsten.etherscan.io/address/0xdd2e010206915b4471955018cdd5b9b52b8afa2c#code) - Slotted this in with one of our releases and forgot to update. Sorry!

@rkalis
Copy link
Owner

rkalis commented Sep 20, 2021

Thanks @Enigmatic331! I'll close this issue now.

@rkalis rkalis closed this as completed Sep 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

5 participants