Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract out the robust application of BufferedImageOps to its own method #50

Closed
ghost opened this issue Oct 28, 2011 · 1 comment
Closed
Milestone

Comments

@ghost
Copy link

ghost commented Oct 28, 2011

BufferedImageOps actually have an 8-year old bug in the JDK that can cause the application of certain types of manipulations to fail with an exception or return a black/empty picture and no exception.

It is maddening.

Fortunately imgscalr works around this internally so all the BufferedImageOps passed in are handled correctly and avoid that failure case in the JDK.

This functionality should be extracted out into its own discrete method so anyone can safely (and efficiently) apply BufferedImageOps against their images even if they aren't performing a resize operation.

This is in the same vein as Issue #49: #49

@ghost
Copy link
Author

ghost commented Nov 18, 2011

Fixed.

The new apply() method does this for callers.

@ghost ghost closed this as completed Nov 18, 2011
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

0 participants