This repository has been archived by the owner on Jun 9, 2020. It is now read-only.
Get support for new 3.5 Python coroutines #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit implement the proper stuff to decorate the new coroutine style implemented by Python3.5 and their new statments, making the canonical `profile` decorator compatible. To hide incompatible 3.5 statements between versions. The idea is be able to run all Python versions, since 2.X to 3.5 without break the current behaviour. The Python 3.5 specific code is hidden into private files that will be imported only in 3.5 environments.
thehesiod
reviewed
Dec 16, 2016
| """ | ||
| Wrap a Python 3.5 coroutine to profile it. | ||
| """ | ||
| @functools.wraps(func) |
There was a problem hiding this comment.
this file is missing import functools
|
Btw, this can be simply rebased on top of the current master and seems to work in Python 3.6.1. |
|
@rkern ping .... |
|
Hm, ok, in Python 3.6, it works when pip-installed in devel mode, but otherwise it crashes with |
|
@Azag0 should be fixed with the last commit |
|
Yep, works now. |
Daenyth
approved these changes
Oct 8, 2017
|
Will try to take a look at it this week. |
|
@caethan any news about that? |
|
Looks good! Thanks for the patience and sorry for the delay in reviewing it. I'll merge it and see about going through other pull requests to see if anything else should get pulled in for a 2.1 release. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit implement the proper stuff to decorate
the new coroutine style implemented by Python3.5 and their new
statments, making the canonical
profiledecorator compatible.To hide incompatible 3.5 statements between versions. The idea is be able
to run all Python versions, since 2.X to 3.5 without break the current behaviour.
The Python 3.5 specific code is hidden into private files that will be imported only in
3.5 environments.