support for sinatra namespaces #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -100,17 +109,22 @@ class RouteHandler < Ruby::Base | |||
| handles method_call(:get) | |||
| handles method_call(:post) | |||
| handles method_call(:put) | |||
| handles method_call(:patch) | |||
There was a problem hiding this comment.
Totally inadvertant. Let me fix that up and re-push
|
❤️ |
|
I've added back the (mistakenly) removed "patch" keyword as well as fixing a bug with nesting namespaces more than one level. This is in a "works for me" and "unit tests pass" state. I'd love any more feedback you might have. |
|
I don't know to much about YARD internals, tbh, but from what I can tell it seems good. Are you using yard-sinatra actively? I use it in one project and am desperately looking for someone to take over maintenance. |
|
I only just started using it in the past couple of weeks but I anticipate that we might be using it more at work to provide API docs for internal services. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This add simple parsing/processing of namespaced routes for sinatra docs (as noted in issue #1). It only manages the URL path of the nested routes and does nothing with any documentation placed on the namespace keyword (docs would still need to be placed on each route declaration).