Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a new approach for identifying authors #3

Closed
dideler opened this issue Feb 22, 2018 · 1 comment
Closed

Use a new approach for identifying authors #3

dideler opened this issue Feb 22, 2018 · 1 comment
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@dideler
Copy link
Contributor

dideler commented Feb 22, 2018

We're using the same name and format for reading authors via a file like git-duet and git-pair does, i.e. .git-authors file. The reason we were doing this is to make the transition easier users.

But another option for easy transition is to provide a simple tool that converts the old file into a new file for git-mob. This way we aren't limited to a design which has certain drawbacks.

We won't need to use the same filename, since .git-authors historically also included the primary author. We could for example name it .git-coauthors to emphasise that it's strictly for co-authors.

We won't need to use YAML which means we can use JSON which will make git-mob commands quicker (don't need to load large third party dependencies which is very slow).

We also won't need to follow the same structure, for example, we can get rid of having multiple values on the same line (e.g. first_name last_name; email_id) which is confusing.

@dideler dideler added the enhancement New feature or request label Feb 22, 2018
@dideler dideler changed the title Use a new format for git-authors Use a new approach for identifying authors Feb 22, 2018
@dideler dideler added this to the 1.0.0 milestone Mar 27, 2018
@rkotze rkotze self-assigned this Mar 30, 2018
@rkotze
Copy link
Owner

rkotze commented Apr 2, 2018

I believe this issue is now fixed with release v0.1.0.

@rkotze rkotze closed this as completed Apr 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants