Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doesn't handle localised timestamps #3

Closed
unhammer opened this issue Aug 14, 2019 · 8 comments · Fixed by #6
Closed

doesn't handle localised timestamps #3

unhammer opened this issue Aug 14, 2019 · 8 comments · Fixed by #6

Comments

@unhammer
Copy link

unhammer commented Aug 14, 2019

I get
må

from

*  Foo
  :LOGBOOK:
  CLOCK: [2018-03-26 må. 13:14]--[2018-03-26 må. 13:43] =>  0:29
  :END:

but it works fine if I change the må.'s to Mon. Emacs by default uses the system locale to get abbreviated weekdays, so you can get Di or må. and so on. I guess a timestamp should be parsable with something like \[([0-9-]+) [^ ]+ ([0-9:]+)\] (where \1 is date and \2 is time and the middle bit is ignored)

@hso
Copy link
Contributor

hso commented Aug 14, 2019

This seems to be what was happening on #1

@rksm
Copy link
Owner

rksm commented Aug 15, 2019

Language is hard :) Thanks for letting me know, will be fixed.

@hso
Copy link
Contributor

hso commented Aug 15, 2019

Fixed in PR #6, if everything looks OK you can just merge it (and that will auto close the relevant issues) :)

@rksm rksm closed this as completed in #6 Aug 15, 2019
@unhammer
Copy link
Author

Should this have been fixed in the 0.3.3 jar? I'm still getting the same output.

@unhammer
Copy link
Author

unhammer commented Aug 27, 2019

This is still not working in 0.3.4 :-(

Was there some regression, should I open a new issue?

@rksm rksm reopened this Aug 27, 2019
@rksm
Copy link
Owner

rksm commented Aug 27, 2019

Sorry for that, I'll investigate.

@rksm rksm closed this as completed in 6ad48e2 Aug 27, 2019
@rksm
Copy link
Owner

rksm commented Aug 27, 2019

Apologies, this should be fixed for real now. There was one additional regexp to find CLOCKs that needed a change. The release is here: https://github.com/rksm/clj-org-analyzer/releases/tag/0.3.5

@unhammer
Copy link
Author

Sweet, it works on my giant work.org file now =D Thanks for the quick fix :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants