Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/mktemp #26

Merged
merged 2 commits into from
Jan 20, 2022
Merged

Fix/mktemp #26

merged 2 commits into from
Jan 20, 2022

Conversation

lassepe
Copy link
Contributor

@lassepe lassepe commented Oct 5, 2021

tempfile is not available on non-debian-based linux distributions. Thus, asdf-julia is currently broken on Arch Linux and most likely macos as well. This fixes things for Arch Linux. I cannot test on macos locally.

tempfile is not available on non-debian-based linux distributions.
@dhanak
Copy link
Contributor

dhanak commented Oct 5, 2021

Works on Debian

@lassepe
Copy link
Contributor Author

lassepe commented Oct 9, 2021

@rkyleg could you review this one? Currently, asdf-julia is broken for non-debian users.

@lassepe
Copy link
Contributor Author

lassepe commented Oct 25, 2021

@rkyleg do you know what is going on with the MacOS CI? It seemed like it was hanging. Now it is disabled completely.

@tdy
Copy link

tdy commented Oct 26, 2021

Works for me locally on Arch. Would be great to get this merged upstream.

@lassepe
Copy link
Contributor Author

lassepe commented Oct 26, 2021

There is something wrong with the MacOS tests still. They are running for more than an hour already and still haven't finished

@lassepe
Copy link
Contributor Author

lassepe commented Oct 26, 2021

Unfortunately, there is no output or error message, it just hangs. So it's really hard to debug.

@FujishigeTemma
Copy link

FujishigeTemma commented Nov 16, 2021

@lassepe The tests fails because the --suffix option doesn't exist in macOS-builtin mktemp(https://www.mktemp.org/manual.html) and hangs at eval $cmd$page >> $releases. And it seemed that the .json suffix isn't always necessary, so I just turned it off and it works on my macOS.

releases=$(mktemp)
headers=$(mktemp)

@lassepe
Copy link
Contributor Author

lassepe commented Jan 5, 2022

Thank you @FujishigeTemma, I pushed that to this branch as well.

@rkyleg woud you consider re-enabling the CI and, if it passes, merge this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants