Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate API key methods #59

Closed
ledell opened this issue Aug 23, 2019 · 2 comments · Fixed by #100
Closed

Deprecate API key methods #59

ledell opened this issue Aug 23, 2019 · 2 comments · Fixed by #100

Comments

@ledell
Copy link
Member

ledell commented Aug 23, 2019

Now that we added OAuth support and the API key authentication scheme is no longer functional, we can deprecate the API key methods.

Current plan is to remove the api_key argument and add ... to swallow any api_key args that appear in old/outdated scripts.

@jennybc
Copy link
Collaborator

jennybc commented Apr 22, 2020

I think -- but I'm not sure -- that it might be easier to just eliminate the API key stuff now. If that seems to be true, do I have encouragement to pursue that / make such a PR?

@ledell
Copy link
Member Author

ledell commented Apr 22, 2020

@jennybc Yeah, there’s no use to the api key code anymore. Feel free to get rid of it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants