Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example in documentation appears incorrect #29

Closed
aravindr93 opened this issue Jul 9, 2016 · 1 comment
Closed

Example in documentation appears incorrect #29

aravindr93 opened this issue Jul 9, 2016 · 1 comment

Comments

@aravindr93
Copy link

aravindr93 commented Jul 9, 2016

Hello. I've just started using rllab, and went through the documentation today. The example of REINFORCE given here appears to be incorrect, or I don't fully understand the implementation.
https://rllab.readthedocs.io/en/latest/user/implement_algo_basic.html

Under the heading Constructing the computational graph, a surrogate function is defined and it's gradient taken. However, isn't the surrogate function itself the gradient? This is as per the pseudo code given in the Preliminary section. Why do we need to compute the gradient again?

Kindly update the documentation or clarify. Thanks!

@aravindr93
Copy link
Author

It was only a minor typo, but can be understood easily in the context of the whole page. My bad. I'm closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant