Update AuthServiceProvider.php #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had to change the JWT Provider from Lcobucci to Namshi, but when I tried to override the config in plugins/rluders/jwtauth/config/jwt.php to config/rluders/jwtauth/jwt.php as described in the OctoberCMS Documentations https://octobercms.com/docs/plugin/settings#file-configuration nothing happened and after searching for the problem turned out the config is not using the OctoberCMS way of loading configs but with a include to fix it I had to copy the loadConfiguration() to my plugin which many people will not do. Also only setting Config::set('jwt', Config::get('rluders.jwtauth::jwt')) will throw a error. The reason I had to change the Providor is after updating the project to 469 (including plugins, without composer). I got this error: "Could not create token: Using integers for registered date claims is deprecated, please use DateTimeImmutable objects instead.". Which is fixable by changing from Lcobucci to Namshi.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to change the JWT Provider from Lcobucci to Namshi, but when I tried to override the config in plugins/rluders/jwtauth/config/jwt.php to config/rluders/jwtauth/jwt.php as described in the OctoberCMS Documentations https://octobercms.com/docs/plugin/settings#file-configuration nothing happened and after searching for the problem turned out the config is not using the OctoberCMS way of loading configs but with a include to fix it I had to copy the loadConfiguration() to my plugin which many people will not do. Also only setting Config::set('jwt', Config::get('rluders.jwtauth::jwt')) will throw a error.
The reason I had to change the Provider is after updating the project to 469 (including plugins, without composer). I got this error: "Could not create token: Using integers for registered date claims is deprecated, please use DateTimeImmutable objects instead.". Which is fixable by changing from Lcobucci to Namshi.