Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md on rm_calibration_controllers #2

Merged
merged 42 commits into from
Aug 25, 2021
Merged

Update README.md on rm_calibration_controllers #2

merged 42 commits into from
Aug 25, 2021

Conversation

ljq-lv
Copy link
Contributor

@ljq-lv ljq-lv commented Aug 21, 2021

No description provided.

qiayuanl
qiayuanl requested changes Aug 21, 2021
View reviewed changes
Copy link
Member

@qiayuanl qiayuanl left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

服务和参数都没有数据类型，其他问题在群里说了一行一行对照

@ljq-lv ljq-lv closed this Aug 21, 2021
@ljq-lv ljq-lv reopened this Aug 21, 2021
@ljq-lv ljq-lv changed the title Add README.md Add README.md on rm_calibration_controllers Aug 21, 2021
@ljq-lv ljq-lv changed the title Add README.md on rm_calibration_controllers Update README.md on rm_calibration_controllers Aug 21, 2021
Edwinlinks
Edwinlinks suggested changes Aug 21, 2021
View reviewed changes
Copy link
Contributor

@Edwinlinks Edwinlinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

删去第四点config，在parameters里面将参数的作用讲述清楚，并且要按照模板写明参数的单位，需要写什么参数看配置文件和代码，存在默认值的要写出默认值

@qiayuanl
Copy link
Member

qiayuanl commented Aug 21, 2021 •
edited
Loading

删去第四点config，在parameters里面将参数的作用讲述清楚，并且要按照模板写明参数的单位，需要写什么参数看配置文件和代码，存在默认值的要写出默认值

不是单位！
还有错误没找出来，一行一行看！

Edwinlinks
Edwinlinks suggested changes Aug 21, 2021
View reviewed changes
Copy link
Contributor

@Edwinlinks Edwinlinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usage写错了，每一个参数，比如effort要写清楚是torque还是force，速度同理，缺了Controller configuration examples这个部分，第5点与5.1的距离太大了，Dependencies那里有一个空出来的“ * ”号，控制器的readme要写状态机的状态解释

@qiayuanl
Copy link
Member

Usage写错了，每一个参数，比如effort要写清楚是torque还是force，速度同理，缺了Controller configuration examples这个部分，第5点与5.1的距离太大了，Dependencies那里有一个空出来的“ * ”号，控制器的readme要写状态机的状态解释

提示：有个数据类型错了

qiayuanl
qiayuanl requested changes Aug 21, 2021
View reviewed changes
Copy link
Member

@qiayuanl qiayuanl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ROS API 至少有一个错误

BruceLannn
BruceLannn reviewed Aug 21, 2021
View reviewed changes
Copy link
Contributor

@BruceLannn BruceLannn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2.1那里改成sudo apt-get install ros-noetic-calibration-controllers

qiayuanl
qiayuanl requested changes Aug 21, 2021
View reviewed changes
Copy link
Member

@qiayuanl qiayuanl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ROS API 还是有两个错误

BruceLannn
BruceLannn requested changes Aug 23, 2021
View reviewed changes
Copy link
Contributor

@BruceLannn BruceLannn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview需要改，看技术报告里面的calibration_controller的简介，Installation的格式有错，去看shooter！

qiayuanl
qiayuanl requested changes Aug 23, 2021
View reviewed changes
Copy link
Member

@qiayuanl qiayuanl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

而且format也没过哦

BruceLannn
BruceLannn requested changes Aug 24, 2021
View reviewed changes
Copy link
Contributor

@BruceLannn BruceLannn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

删掉前面的序号既1.Overview改为Overview，license的链接是云台的还有ros_best_practices？！还有在overview里面加硬件接口，看shooter里面怎么写的，然后内容看技术报告

qiayuanl
qiayuanl requested changes Aug 25, 2021
View reviewed changes
Copy link
Member

@qiayuanl qiayuanl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ROS API 里面仍然有错的地方，看技术文档！！一行一行看！

qiayuanl
qiayuanl requested changes Aug 25, 2021
View reviewed changes
Copy link
Member

@qiayuanl qiayuanl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

改的附近仍然错误！！！！一行一行看！！！！！！！！！！！！！！！！！！！！！！！！！！！！！！！！！！！！！！！！！！！！！！！！！！！！！！！！！！！！！！！！！！！！！

@qiayuanl qiayuanl merged commit d257f90 into rm-controls:master Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiayuanl qiayuanl qiayuanl requested changes

@BruceLannn BruceLannn BruceLannn requested changes

@Edwinlinks Edwinlinks Edwinlinks requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ljq-lv @qiayuanl @BruceLannn @Edwinlinks