Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better documentation #2

Closed
sahilsehwag opened this issue Jun 7, 2021 · 2 comments · Fixed by #3
Closed

Better documentation #2

sahilsehwag opened this issue Jun 7, 2021 · 2 comments · Fixed by #3

Comments

@sahilsehwag
Copy link

Documentation doesn't mention what's the default mapping
Documentation doesn't mention how to set custom mapping
@rmagatti
Copy link
Owner

rmagatti commented Jun 7, 2021 •
edited
Loading

Hi, thanks for the submission!

Fair points, I'll add these up.

I might actually want to just remove the mappings dependency on vmpeccable while I'm at it, it's great but the plugin shouldn't expect people to use it.

@rmagatti rmagatti mentioned this issue Jun 7, 2021
Merged
@rmagatti
Copy link
Owner

rmagatti commented Jun 7, 2021

@sahilsehwag the linked PR above should also address the lack of mappings documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not depend on vimp and update readme with default mappings rmagatti/goto-preview
2 participants
@rmagatti @sahilsehwag