Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize in/out decorators #1

Open
rmallols opened this issue Dec 1, 2014 · 0 comments
Open

Normalize in/out decorators #1

rmallols opened this issue Dec 1, 2014 · 0 comments

Comments

@rmallols
Copy link
Owner

rmallols commented Dec 1, 2014

At the moment the inDecorator / outDecorator mechanism looks wierd:

  • inDecorator uses to return 'query' but I think it's actually returning 'req' if the method has not actually defined. I guess it should return always 'req' as we started to draft on the item creation (app.post...)
  • The name of the inDecorator method is called 'filter', but this is strange for instance on user creation, as we are not filtering but encrypting the password.
  • outDecorators must be checked as well.
  • Please check whether the current implementaton of the find options (read.js -> _getNormalizeFindOptions) works fine, as I have the feeling if you specify any of the custom properties (query, projection, sort...) this is never going to work
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant