shellcheck conformity

[AladW]

Right now, it's not pretty with 343 warnings, mostly quoting errors:

shellcheck -f gcc /usr/bin/pacaur | wc -l
343

Some warnings can be suppressed with -e, for example:

/usr/bin/pacaur:64:1: warning: Can't follow non-constant source. Use a directive to specify location. [SC1090]

would be shellcheck -e 1090

See also #457.

[rmarquis]

See also #175 and #315. I had done some shellcheck cleanup in the past, but some of them actually introduced issues so I didn't aim to a 100% pass on shellcheck test. Might be worth having a look again.

[rmarquis]

Partially done in 580261c.

Ignoring some warnings that doesn't make sense in this context, we get:

$shellcheck -f gcc ./pacaur -e 2053 -e 2068 -e 2086 -e 2076 -e 1090 -e 1091 -e 2034 -e 1001 -e 2174 -e 2153 | wc -l
21

[rmarquis]

Note: #490 issue is due to SC2068, and should also be fixed.

[rmarquis]

Closing this ticket now, since I'll likely not do this by myself. Further work can be tracked in #443 where better code is discussed.