Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cacert.pem to latest version (2020-01-01) #385

Merged
merged 2 commits into from
Oct 18, 2020
Merged

Update cacert.pem to latest version (2020-01-01) #385

merged 2 commits into from
Oct 18, 2020

Conversation

patmead
Copy link
Contributor

@patmead patmead commented May 15, 2020

@patmead patmead mentioned this pull request May 15, 2020
@patmead
Copy link
Contributor Author

patmead commented May 15, 2020

This update does cause an error in the PHP 5.3 test script, but I hope that's an acceptable compromise given that:

(As an aside, that same document claims that "HTTPS requests will use the most secure options available" so hopefully this PR will bring us in line with that ;) )

@ozh
Copy link
Collaborator

ozh commented May 15, 2020

Tests are flaky and easily timeout. I've triggered the build again and 5.3 pass, so I assume everything is fine with your PR

@ozh
Copy link
Collaborator

ozh commented May 15, 2020

@rmccue we would really need you to ease the check status requirement to allow merging in such a situation

@patmead
Copy link
Contributor Author

patmead commented Jun 23, 2020

@rmccue Could you hit the Merge button on this approved PR? If there's anything blocking this from being merged please let me know!

@ozh ozh merged commit a73a7b3 into WordPress:master Oct 18, 2020
@jrfnl jrfnl added this to the 1.7.1 milestone Oct 18, 2020
@jrfnl
Copy link
Member

jrfnl commented Oct 18, 2020

The previous PRs for this - #212, #330 and #333 - contained discussion about adjustments made to the certificate for compatibility. I'm not sure those adjustments were made in this PR which has now been merged. It might be a good idea for someone who involved to have a critical look if another update is needed to this before a release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CA Bundle is out of date
3 participants