Feature request - light mode

[dakennguyen]

Hi, I love the combination of one and nord theme. Nord theme doesn't support light mode, but one theme has light mode. Maybe this is too much to ask but what do you think about having a light mode for onenord? At first, we can build it from onelight's colors, and then create our own light version of nord later where we see fit.

If you are interested, I'm willing to give a hand if you need any help 😄

[rmehri01]

Hi again! I think that's a good idea, I'll try out some colors and see if I can get something that fits well. Theoretically it shouldn't be too hard to do since I just need to make another color palette but I'd appreciate your help with testing it out later 😄

[dakennguyen]

awesome, thank you!! I'll wait for your update then

[rmehri01]

Alright, I just changed some colors around and here is what I have so far. I think it's not too bad but some of the contrast seems a bit off. I don't have much experience with light mode themes so what do you think:

[dakennguyen]

I think it looks nice!!! But not sure if the yellow is too bright or not 🤔 Would you mind pushing the branch so I can further test it on some of my languages?

Ah, also I think we could try to gray out the background a little bit to see how it goes (like these https://levelup.gitconnected.com/10-pretty-light-themes-for-vs-code-80dbf6405f39). One theme background is black so the opposite is white, while our background is not entirely black so gray background for the opposite maybe also make sense!

[rmehri01]

Would you mind pushing the branch so I can further test it on some of my languages?

Sure, let me clean it up a bit first and then I'll make a pr for it and tag you.

Ah, also I think we could try to gray out the background a little bit to see how it goes

Yeah I think that might be a good idea, I'll try it out after!

[VKondakoff]

Is there a way to switch themes "on the fly"? (I'm thinking about switching themes together with the system light/dark mode auto-switching).

Using :set background=light command does not switch the theme and setting vim.o.background in init.lua works only after restarting nvim. How can I switch Onenord theme without restarting nvim?

Thank you!

[rmehri01]

Hi! I've just been using :colorscheme onenord and :colorscheme onenordlight, but I think your way is better since there's only 2 themes. I just pushed a change for it!

[VKondakoff]

Thanks, works like a charm! 👍