Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add equality testing #122

Open
jmeyers314 opened this issue Jan 6, 2021 · 1 comment
Open

Add equality testing #122

jmeyers314 opened this issue Jan 6, 2021 · 1 comment

Comments

@jmeyers314
Copy link
Collaborator

Can we add __eq__ methods to Piff objects? I wanted to write a test over in Rubin-land that roundtrip serialization to FITS (using the Rubin framework) works, but was stymied by the inability to check if the original and retrieved SimplePSF objects were actually the same. For now I can just check if some sample PSF images come out the same, but it'd be nice to just assert original_psf == roundtrip_psf.

@rmjarvis
Copy link
Owner

rmjarvis commented Jan 7, 2021

Sure. Fine by me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants