Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add defcustom to configure a path between host and filename #92

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jvtrigueros
Copy link

I ran into an issue where my remote type was using gitiles type, but between the host and the filename there was a custom path. At first, I tried to solve this with add-advice but it quickly became a mess, so it was much easier to provide this as an option.

browse-at-remote-append-path-to-host allows users of the package to customize the remote URL if needed:

<web-proto>://<host><path><filename>

This is my first PR to an emacs package so I'm not sure if this is the best way to go about it.

@cpaulik
Copy link

cpaulik commented Aug 29, 2022

Could this be generalized to a full host replacement?

I'm looking into a fix for #70

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants