Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit (and doc) tests for de_impl_opt.rs #7

Open
rnag opened this issue Mar 20, 2023 · 0 comments
Open

Add unit (and doc) tests for de_impl_opt.rs #7

rnag opened this issue Mar 20, 2023 · 0 comments

Comments

@rnag
Copy link
Owner

rnag commented Mar 20, 2023

There seems to be some differing assumptions on what should be None and what shouldn't.

I find the examples section hard to read. Rather than having many examples, it may be better to have unit tests - and examples (doc tests) in src/de_impl_opt.rs doc strings.

Somewhere there should be a dense table/section where the behaviour can be seen at a glance - possibly in the doc string itself. I like the # Returns section, explaining behaviour, but this could be complemented with more comprehensive cases for each of the input types str, i64, f64, u64.

Originally posted by @corneliusroemer in #5 (review)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant