Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the UI work without instance-access #34

Open
falkTX opened this issue Dec 15, 2020 · 2 comments
Open

Make the UI work without instance-access #34

falkTX opened this issue Dec 15, 2020 · 2 comments

Comments

@falkTX
Copy link

falkTX commented Dec 15, 2020

Hello again :)

This is a feature request, for which we at MOD Devices are willing to submit a PR to.
We have been looking into samplv1 and the steps to make it all work without instance-access are within small reach:
1 - properly save and restore lv2 parameter data as part of the plugin state, see #33
2 - notify the UI when these parameters are changed by the host (as part of state restore)
3 - when loading a sample, make an atom float-vector of its peaks to send to UI

That should do it. It is already quite close since you are using the lv2 parameter APIs for file management.

I don't expect you to do any work here, just wanted to start the conversation about this.
We (at MOD) will be pushing a PR soon that achieves this, just wanted to mention this, as perhaps you have any important things to note or even objections.
Thanks

@rncbc
Copy link
Owner

rncbc commented Dec 15, 2020

eagerly awaiting the PR...
I must say I'll be surprised if it doesn't break it all loose into a mess and/or a very different code-base ... just to please MOD Devices? ;) your call anyway... maybe a new branch, perhaps?

@falkTX
Copy link
Author

falkTX commented Dec 16, 2020

nah, we want to keep this as close as possible to upstream.
the build system is the odd one, because we need to build without GUI support.

since it was me confused on issue 1 above, the actual work to do is considerably quite small then.
for a first iteration, we just need to notify the UI when a state restore happened, so it re-sends all "internal" parameter values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants