Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Looping forwards and backwards #9

Open
io7m opened this issue Aug 20, 2017 · 4 comments
Open

Looping forwards and backwards #9

io7m opened this issue Aug 20, 2017 · 4 comments

Comments

@io7m
Copy link

io7m commented Aug 20, 2017

Hello!

I've just discovered samplv1 today and it seems excellent. One feature request: Is there any chance you could add the ability to loop forwards and backwards through the selected loop points? This can result in a much more natural sound when looping sustained samples such as wind instruments, synth pad sounds, etc.

To clarify: The current loop algorithm starts looping at point P0 and continues through the sample until it reaches point P1. Then, it restarts at P0 and repeats this process endlessly. I'd love it if you could add a looping mode that starts looping at point P0, continues through the sample until it reaches P1, and then reverses direction and travels backwards through the sample until it reaches P0 again. When it reaches P0, the process repeats.

@rncbc
Copy link
Owner

rncbc commented Sep 8, 2017

sorry for this late. i fully understand what you're asking. however the current (rom/sam)pler engine only runs in the forward time direction.
but please, don't stop it there. if you have some C/C++ coding skills, it might be a good chance for you to apply for a PR in here ;)
just feel welcome, nevertheless.
cheers

@io7m
Copy link
Author

io7m commented Sep 8, 2017

'Ello.

I have about ten years experience writing C/C++ but haven't written any for many years. If you could give me some pointers as to where the changes would need to be made, I could certainly have a go at it.

@rncbc
Copy link
Owner

rncbc commented Sep 8, 2017

of course if the idea was easy to implement i would do it myself :)
looking into samplv1_sample.h/cpp module classes should be enough, i guess.

samplv1_sample and samplv1_generator are the classes to investigate and possibly refactor.

byee

@io7m
Copy link
Author

io7m commented Sep 8, 2017

Ok, sounds good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants