Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

64 MiB piece size suggestion #8

Closed
rr- opened this issue Jun 26, 2019 · 5 comments
Closed

64 MiB piece size suggestion #8

rr- opened this issue Jun 26, 2019 · 5 comments

Comments

@rr-
Copy link
Contributor

rr- commented Jun 26, 2019

It appears that for large torrents, 64 MiB is the maximum piece size that can be chosen.

While I realize this can be overridden by hand, I'd suggest to lower this bound by default, as uTorrent, one of the most popular clients, seems to be unable to handle such large piece sizes. Naturally, that's their problem and not this library's, but in the end it's the users (the ones who download the torrent) who are hurt the most and I discovered it the hard way ^^

@rndusr
Copy link
Owner

rndusr commented Jun 26, 2019 via email

@rr-
Copy link
Contributor Author

rr- commented Jun 26, 2019

In the end I didn't manage to establish what the maximum commonly supported piece size is, but I started to limit it to 4 MiB and so far received no complaints. That might be a bit too extreme, though.

@rr-
Copy link
Contributor Author

rr- commented Jun 26, 2019

https://wiki.theory.org/index.php/BitTorrentSpecification says:

Current best-practice is to keep the piece size to 512KB or less, for torrents around 8-10GB, even if that results in a larger .torrent file. This results in a more efficient swarm for sharing files. The most common sizes are 256 kB, 512 kB, and 1 MB.

After reading these guidelines, I think I might decrease it even further down to 1 MiB. But yeah that article is just a recommendation, whereas my original report was about software that downright refuses to download the torrents of certain sizes. Unfortunately I cannot comment precisely on what is safe and what is not.

@rndusr
Copy link
Owner

rndusr commented Jun 26, 2019 via email

@rr-
Copy link
Contributor Author

rr- commented Jun 26, 2019

Yes, thank you, definitely, I was good even before with the manual override of piece size exceeding 4 MiB in my scripts. I only wanted to bring to your attention that there were users who would have troubles with torrents created by the prior implementation. Closing the issue :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants