Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_key_lifetime failing #10

Open
maxirmx opened this issue Apr 6, 2024 · 4 comments
Open

test_key_lifetime failing #10

maxirmx opened this issue Apr 6, 2024 · 4 comments

Comments

@maxirmx
Copy link
Member

maxirmx commented Apr 6, 2024

=================================== FAILURES ===================================
______________________________ test_key_lifetime _______________________________

    def test_key_lifetime():
        rpgp = rnp.Rnp()
        rpgp.load_keys(rnp.Input.from_path("tests/data/keyrings/gpg/secring.gpg"), "GPG")
        key = rpgp.find_key_by_id("7bc6709b15c23a4a")
        key.unlock("password")
        assert key.lifetime() == 0
        key.set_lifetime(1234)
>       assert key.lifetime() == 1234
E       assert 0 == 1234
E        +  where 0 = <bound method Key.lifetime of <rnp.key.Key object at 0x10be2bd50>>()
E        +    where <bound method Key.lifetime of <rnp.key.Key object at 0x10be2bd50>> = <rnp.key.Key object at 0x10be2bd50>.lifetime

tests/test_key_lifetime.py:11: AssertionError
=========================== short test summary info ============================
FAILED tests/test_key_lifetime.py::test_key_lifetime - assert 0 == 1234
======================== 1 failed, 87 passed in 10.83s =========================
ERROR: InvocationError for command /Users/runner/work/py-rnp/py-rnp/.tox/py311/bin/poetry run pytest -v (exited with code 1)
___________________________________ summary ____________________________________
@maxirmx
Copy link
Member Author

maxirmx commented Apr 6, 2024

@ni4
Could you please advise what has changed in the core rnp ?

@ni4
Copy link

ni4 commented Apr 7, 2024

@maxirmx Looks like it's because SHA-1 deprecation for key signatures since January 2024. I'll take a look, most likely we should re-create artifact with other hash algo or update tests to allow SHA-1.

@maxirmx
Copy link
Member Author

maxirmx commented Apr 7, 2024

@ni4 I can change to SHA256 I guess. Should not be that difficult

@ni4
Copy link

ni4 commented Apr 8, 2024

@maxirmx Ok, feel free to follow up if something goes wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants