Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract out keystore code to librekey #308

Open
ronaldtse opened this issue Jul 17, 2017 · 3 comments
Open

Extract out keystore code to librekey #308

ronaldtse opened this issue Jul 17, 2017 · 3 comments
Milestone

Comments

@ronaldtse
Copy link
Contributor

Description

Keystore handling code should be extracted out to librekey. Need a keystore interface for interacting with keystore operations.

Keystore operations:

  • Store key
  • Fetch/Find key
  • Edit key
  • Key metadata / properties
  • Maybe some trust related data (as metadata?)

rnp should depend on librekey and utilize the general keystore interface to interact with all keystores.

This includes:

  • PGP keyring
  • g10 key directory (private-keys.v1.d)
  • KBX format
  • SSH keychain
@ronaldtse ronaldtse modified the milestone: librekey Jul 18, 2017
This was referenced Jul 28, 2017
@ni4
Copy link
Contributor

ni4 commented Sep 3, 2019

@ronaldtse @dewyatt Should we close this since we ended up with the single library?

@ronaldtse
Copy link
Contributor Author

@ni4 a shame we weren't able to do generalize the keystone mechanisms... Do you think this will remain useful for the future?

@ni4
Copy link
Contributor

ni4 commented Sep 3, 2019

@ronaldtse Actually it's not a shame but impossibility to separate key packets/other packets loading/parsing/composition. The only way I see is to have separate libs for keyring format(s) which are dependent on base lib, where base lib operates with only OpenPGP packet sequences (transferable public/secret keys). So g10/kbx code can be separated, but it still will use base library's code to build up key structures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants