-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please add option to build as a shared library #32
Comments
Alternately, just merge it into librnp directly as source, rather than keeping it separate. Using git submodules makes it significantly more challenging to have a reliable packaging workflow. |
@dkg latest release (v0.17.0) includes sexp sources in non-snapshot packages ( |
@andreasstieger , @remicollet, @dkg thank you for your notes Generally speaking we do not want to expose sexp as a separate entity
I can readily accept that any or all of the items above are wrong but I am afraid I need some help to understand the issue. |
Speaking for the openSUSE packagers, based on our shared library packaging policy, which is more or less the same in most major distributions: We avoid packaging static libraries at any cost. We literally patch rnp until it is a shared library. We further unbundle sexp into a shared library by itself as a standalone source package, building a lib, a -devel and a cli package. We will proceed to do the same in Thunderbird next, to use the system Botan or OpenSSL. Could be trivially be made into a build-time configurable option. |
Thank you, @andreasstieger sexp static library is an intermmediate build step. There are other static libraries created during rnp build that are intermmediate build steps as well. I suggest that you do not patch it; do not package libsexp.a; just deleted it, if it is not deleted by rnp build script. |
Actually we patch rnp to not build and statically link it's bundled sexp but use the distribution sexp shared library. |
I think we have sufficiently good reasons to execute this ticket as is. Thank you all for raising this! @maxirmx it's all yours, thank you! |
Gentoo Linux also packages sexp as a separate library package https://gitweb.gentoo.org/repo/gentoo.git/tree/dev-util/librnp/files/librnp-0.17.0-dont-bundle-sexp.patch |
So can later be packaged separately and used by rnp, instead of using bundled copy
The text was updated successfully, but these errors were encountered: