Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added an option to build shared library #34

Merged
merged 3 commits into from
Jun 20, 2023
Merged

Conversation

maxirmx
Copy link
Member

@maxirmx maxirmx commented Jun 15, 2023

Added an option to build shared library #32

@codecov
Copy link

codecov bot commented Jun 15, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (b6bf033) 99.70% compared to head (b960afe) 99.70%.

❗ Current head b960afe differs from pull request most recent head 137e043. Consider uploading reports for the commit 137e043 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #34   +/-   ##
=======================================
  Coverage   99.70%   99.70%           
=======================================
  Files           9        9           
  Lines         668      668           
=======================================
  Hits          666      666           
  Misses          2        2           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@maxirmx maxirmx force-pushed the maxirmx-shared-lib branch 6 times, most recently from ed6608e to 69c6442 Compare June 17, 2023 08:19
@maxirmx maxirmx requested a review from ronaldtse June 17, 2023 08:26
@maxirmx maxirmx marked this pull request as ready for review June 17, 2023 08:49
@maxirmx maxirmx linked an issue Jun 17, 2023 that may be closed by this pull request
@maxirmx maxirmx requested a review from ni4 June 17, 2023 08:51
@maxirmx
Copy link
Member Author

maxirmx commented Jun 17, 2023

@remicollet, @andreasstieger
Hope this is the change you are looking for. Thanks

Copy link

@ni4 ni4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Contributor

@ronaldtse ronaldtse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @maxirmx !

@ronaldtse ronaldtse merged commit 05e952b into main Jun 20, 2023
55 checks passed
@ronaldtse ronaldtse deleted the maxirmx-shared-lib branch June 20, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please add option to build as a shared library
3 participants