Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not installing/packaging static libraries in shared libraries bundle #2076

Merged
merged 1 commit into from
May 9, 2023

Conversation

maxirmx
Copy link
Member

@maxirmx maxirmx commented May 3, 2023

No description provided.

@codecov
Copy link

codecov bot commented May 3, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (554ced3) 83.48% compared to head (c11cf32) 83.48%.

❗ Current head c11cf32 differs from pull request most recent head 3908b5f. Consider uploading reports for the commit 3908b5f to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2076   +/-   ##
=======================================
  Coverage   83.48%   83.48%           
=======================================
  Files         159      159           
  Lines       31957    31957           
=======================================
+ Hits        26679    26680    +1     
+ Misses       5278     5277    -1     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@maxirmx maxirmx marked this pull request as ready for review May 3, 2023 20:09
@remicollet
Copy link
Contributor

I confirm this PR fix the issue of static libraries being installed when BUILD_SHARED_LIBS is on.

src/lib/CMakeLists.txt Outdated Show resolved Hide resolved
@maxirmx maxirmx requested a review from ni4 May 4, 2023 19:06
Copy link
Contributor

@ni4 ni4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Contributor

@ronaldtse ronaldtse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @maxirmx !

@ronaldtse ronaldtse merged commit 8f7b2f2 into main May 9, 2023
@ronaldtse ronaldtse deleted the maxirmx-no-static-libs branch May 9, 2023 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants